Skip to content

CLN: reorganise vars in Styler init #39642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2021

Conversation

attack68
Copy link
Contributor

@attack68 attack68 commented Feb 7, 2021

Trying to clean up Styler class grouping and ordering variables and adding typing where necessary.

@jreback jreback added Refactor Internal refactoring of code Styler conditional formatting using DataFrame.style labels Feb 7, 2021
@jreback jreback added this to the 1.3 milestone Feb 7, 2021
@jreback
Copy link
Contributor

jreback commented Feb 7, 2021

sure can you merge master and ping on green.

@attack68
Copy link
Contributor Author

attack68 commented Feb 8, 2021

@jreback merged and green

self.index = data.index
self.columns = data.columns

assert isinstance(data, DataFrame)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is superfluous, if you can remove in a followon (see L161)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was added otherwsise mypy complains about mismatched type. maybe there is a better way..?

@jreback jreback merged commit a515bdd into pandas-dev:master Feb 8, 2021
@jreback
Copy link
Contributor

jreback commented Feb 8, 2021

thanks @attack68

@attack68 attack68 deleted the clean_structure branch February 10, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code Styler conditional formatting using DataFrame.style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants