CLN: reorganise vars in Styler init
#39642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Refactor
|
sure can you merge master and ping on green. |
|
@jreback merged and green |
jreback
approved these changes
Feb 8, 2021
| self.index = data.index | ||
| self.columns = data.columns | ||
|
|
||
| assert isinstance(data, DataFrame) |
There was a problem hiding this comment.
this is superfluous, if you can remove in a followon (see L161)
There was a problem hiding this comment.
this was added otherwsise mypy complains about mismatched type. maybe there is a better way..?
|
thanks @attack68 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to clean up Styler class grouping and ordering variables and adding typing where necessary.